-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Use versioned docker image tags
#9797
Open
magaupp
wants to merge
3
commits into
develop
Choose a base branch
from
feature/programming-exercises/versioned-build-images
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Programming exercises
: Use versioned docker image tags
#9797
magaupp
wants to merge
3
commits into
develop
from
feature/programming-exercises/versioned-build-images
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
config-change
Pull requests that change the config in a way that they require a deployment via Ansible.
label
Nov 16, 2024
magaupp
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
November 16, 2024 14:51
— with
GitHub Actions
Inactive
github-actions
bot
removed
the
programming
Pull requests that affect the corresponding module
label
Nov 16, 2024
magaupp
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
November 16, 2024 15:20
— with
GitHub Actions
Inactive
10 tasks
BBesrour
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm. the image digest and size changed, but that's expected according to @magaupp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config-change
Pull requests that change the config in a way that they require a deployment via Ansible.
ready for review
small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Currently, some docker images use the
latest
tag, which always points to the latest version of the image. When the image updates, exercises which depend on the previous behavior would break.Description
Where the images were missing a version tag, the
v1.0.0
tag was added to the docker repository.We do not have access to the images
tizianleonhardt/era-artemis-vhdl
andtizianleonhardt/era-artemis-assembler
, so repositories within thels1intum
organization were created with images containing the same exact tool versions.This PR changes the default configuration to always use versioned tags.
Steps for Testing
Prerequisites:
For each language and project type of the changed images:
- If the tested image is not the default image:
The template result of the VHDL exercise does not build. This did not change. Verify that the solution build succeeds.
The solution result of the C default exercise fails TestOutputLSan. This did not change.
Adding a tag to the GitHub repos causes a rebuild of the image. This can result in a different image hash, but it should be based on the same dependencies using the same tools.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Manual Tests
Test Coverage
Screenshots